[Webkit-unassigned] [Bug 25770] [chromium] Crash in FontFallbackList::determinePitch(const Font* font)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 1 20:07:03 PST 2010


--- Comment #9 from David Levin <levin at chromium.org>  2010-12-01 20:07:02 PST ---
(In reply to comment #7)
> Created an attachment (id=75345)
 --> (https://bugs.webkit.org/attachment.cgi?id=75345&action=review) [details]
> A copy-and-paste fix (including refactoring)
> (In reply to comment #6)
> > (In reply to comment #5)
> > > Do we need refactoring for this file so we can move all these static functions in this file at the beginning of this file?
> > 
> > Short answer: Sounds good.
> Thank you for your comment. I have moved all the static functions at the beginning of this file because it is pretty easy. (That is, the functionality is the same as the previous one.) Is it possible to take another look?

Please just commit the previous patch as it was (with the fixed) and then do the clean up in a separate patch. Otherwise by putting all of this in one patch, it hides what the fix was for the bug. 

When someone goes back in the history of the file to determine why a line of code changed, they will see a patch that says "Move static functions to top of file to match chromium style with no code changes" or something like that, and they can skip over that change.

If they happen to get to a line that was added/changed for "Crash in FontFallbackList::determinePitch(const Font* font)", then they will know it was fixing that issue (and not related to a code rearrangement).

I say all this due to experiences where I've been the person digging through the history of files.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list