[Webkit-unassigned] [Bug 50344] wss (websockets ssl) support for gtk via new gio TLS support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50344





--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2010-12-01 17:26:26 PST ---
(From update of attachment 75301)
View in context: https://bugs.webkit.org/attachment.cgi?id=75301&action=review

Awesome! The addition of SSL socket support in GIO is great news. Will it need to be behind some version guards though, so that we will still work properly with older GIO versions?

> WebCore/platform/network/soup/SocketStreamHandleSoup.cpp:90
> +	g_socket_client_set_tls(socketClient.get(), TRUE);

Indentation is slightly off here.

> WebCore/platform/network/soup/SocketStreamHandleSoup.cpp:165
> +    if (error && ! g_error_matches(error.get(), G_IO_ERROR, G_IO_ERROR_WOULD_BLOCK)) {

One extra space between ! and g_error_matches.

> WebCore/platform/network/soup/SocketStreamHandleSoup.cpp:274
> -    // G_IO_HUP and G_IO_ERR are are always active. See:
> -    // http://library.gnome.org/devel/gio/stable/GSocket.html#g-socket-create-source
> -    if (condition & G_IO_HUP) {
> -        handle->close();
> -        return FALSE;
> -    }
> -    if (condition & G_IO_ERR) {
> -        handle->client()->didFail(handle, SocketStreamError(0)); // FIXME: Provide a sensible error.
> -        return FALSE;
> -    }
> -    if (condition & G_IO_OUT)
> -        handle->writeReady();
> +    handle->writeReady();

Are connection erros (such as HUP) still handled properly?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.