[Webkit-unassigned] [Bug 50299] webkit-patch needs land-no-bug

Wed Dec 1 16:35:36 PST 2010

https://bugs.webkit.org/show_bug.cgi?id=50299

--- Comment #12 from Dirk Pranke <dpranke at chromium.org>  2010-12-01 16:35:36 PST ---
(In reply to comment #11)
> > It's not clear to me why webkit-patch land doesn't do the missing steps, since these steps tend to be idempotent. It would seem to me like if you didn't want to step through the prompts, then that's what --non-interactive should be for.
> 
> land is optimized for patches that have already been reviewed via the normal WebKit process.  Such patches already have ChangeLogs and have been checked for style by both humans and bots.
>

It doesn't seem like doing the steps anyway makes things much slower for 'webkit-patch upload'. Would it significantly slow down land?

> > Also, when I do webkit-patch land, it never does a build or runs tests. I don't know offhand what to make of that discrepancy.
> 
> You can have it build and test using the --build and --test flags, respectively.  They used to be on by default but were turned off by default by popular demand.

I see.

We should add a "webkit-patch list-steps 'command'" :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.