[Webkit-unassigned] [Bug 50004] [GTK] Need 'webview-cache-model' property in WebKitWebSettings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50004





--- Comment #9 from Martin Robinson <mrobinson at webkit.org>  2010-12-01 08:07:33 PST ---
(From update of attachment 74727)
View in context: https://bugs.webkit.org/attachment.cgi?id=74727&action=review

I think this is a good change. I see an issue with this patch though. The Mac port sets the cache model in didPerformFirstNavigation only if it's autodetected. Otherwise it sets the model as soon as the preferences change. We should replicate that behavior.

> WebKit/gtk/webkit/webkitprivate.h:311
> +    void webViewSetCacheModel(WebKitCacheModel model);
> +

This only seems to be used in webkitwebview.cpp, so it should be static and private to that file.

> WebKit/gtk/webkit/webkitwebview.cpp:4863
> + * Deprecated: Use WebKitWebSettings:webview-cache-model property instead.

Should be "Use the"

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.