[Webkit-unassigned] [Bug 50226] [GTK] Media icons are loaded again every time style-set signal is emitted on every widget

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50226


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75126|review?                     |review-
               Flag|                            |




--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2010-12-01 06:55:46 PST ---
(From update of attachment 75126)
View in context: https://bugs.webkit.org/attachment.cgi?id=75126&action=review

Awesome patch. Just a couple issues outlined below.

> WebCore/platform/gtk/RenderThemeGtk.cpp:199
> +    g_signal_connect(gtk_icon_theme_get_default(), "changed", G_CALLBACK(gtkIconThemeChanged), const_cast<RenderThemeGtk*>(this));

Do you really need a const_cast here?

> WebCore/platform/gtk/RenderThemeGtk.cpp:794
> +    initMediaStyling(true);

This also reinitializes the media colors when the icon theme changes. Perhaps it would make sense to have two methods: initMediaColors and initMediaIcons.

> WebCore/platform/gtk/RenderThemeGtk.h:142
> +    virtual void initMediaColors(GtkStyle*);
>      virtual void initMediaStyling(bool force);

Why are these virtual? Does any subclass override them?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.