[Webkit-unassigned] [Bug 50225] [GTK] Use gtk_widget_render_icon() to render media buttons using gtk stock icons

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50225


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75124|review?                     |review-
               Flag|                            |




--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2010-12-01 06:38:16 PST ---
(From update of attachment 75124)
View in context: https://bugs.webkit.org/attachment.cgi?id=75124&action=review

Great. Just a couple small issues.

> WebCore/platform/gtk/RenderThemeGtk.cpp:60
> +#define WEBKIT_MEDIA_BUTTON_SIZE "webkit-media-button-size"

I think you should just use this this directly.

> WebCore/platform/gtk/RenderThemeGtk.cpp:77
> +        RefPtr<BitmapImage> img = BitmapImage::create();
> +        return img.release();

No need to cache this. You can simply return BitmapImage::create();

> WebCore/platform/gtk/RenderThemeGtk.cpp:91
> +    RefPtr<BitmapImage> img = BitmapImage::create(surface);
> +    return img.release();

Same here, I believe.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.