[Webkit-unassigned] [Bug 40651] Use "typedef wchar_t JSChar" when compiled with RVCT

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40651





--- Comment #16 from Kwang Yul Seo <kwangyul.seo at gmail.com>  2010-08-31 21:41:56 PST ---
(In reply to comment #15)
> (From update of attachment 65732 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=65732&action=prettypatch
> 
> > JavaScriptCore/wtf/unicode/qt4/UnicodeQt4.h:59
> > -#if defined(Q_OS_WIN) || COMPILER(WINSCW) || (COMPILER(RVCT) && OS(SYMBIAN))
> > +#if defined(Q_OS_WIN) || COMPILER(WINSCW) || (COMPILER(RVCT) && !OS(LINUX))
> It's unclear to me why we're switching from a whitelist to a blacklist for something that's identified as a hack...


We can detect Linux with defined(__linux__) and Symbian with defined(__SYMBIAN32__), but there is no such macro in Brew MP. Therefore, it is very hard to check Brew MP in JSStringRef.h. 

Because Linux is the only exception for now, I think it is okay to switch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.