[Webkit-unassigned] [Bug 44759] [EFL] Add custom network resource handler

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44759


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #65700|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #3 from Adam Barth <abarth at webkit.org>  2010-08-31 19:47:38 PST ---
(From update of attachment 65700)
View in context: https://bugs.webkit.org/attachment.cgi?id=65700&action=prettypatch

> WebCore/loader/FrameLoader.cpp:3523
> +#if PLATFORM(EFL)
> +bool FrameLoaderClient::shouldHandleScheme(const String& scheme)
> +{
> +    return false;
> +}
> +
> +void* FrameLoaderClient::handleScheme(const KURL url, String& mime, size_t* bytesRead)
> +{
> +    return 0;
> +}
> +#endif
These implementations are misplaced.  Why are you putting FrameLoaderClient impls in FrameLoader.cpp?

> WebCore/loader/FrameLoaderClient.h:271
> +#if PLATFORM(EFL)
> +        virtual bool shouldHandleScheme(const String&);
> +        virtual void* handleScheme(const KURL, String&, size_t*);
> +#endif
Why would these functions be EFL-specific?  I don't think these make sense here.

> WebCore/platform/network/soup/ResourceHandleSoup.cpp:131
> +#if PLATFORM(EFL)
> +static bool startPersonalHandler(ResourceHandle* handle, KURL url);
> +#endif
Adding EFL ifdefs to ResourceHandleSoup isn't the right approach.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.