[Webkit-unassigned] [Bug 42058] [BREWMP] Don't pass PassOwnPtr in makeAllDirectories

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 31 19:41:10 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=42058


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #65717|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #6 from Adam Barth <abarth at webkit.org>  2010-08-31 19:41:10 PST ---
(From update of attachment 65717)
View in context: https://bugs.webkit.org/attachment.cgi?id=65717&action=prettypatch

> WebCore/platform/brew/FileSystemBrew.cpp:134
> -static bool makeAllDirectories(PassOwnPtr<IFileMgr> fileMgr, const String& path)
> +static bool makeAllDirectories(IFileMgr* rawFileMgr, const String& path)
rawFileMgr isn't the right name here, for sure.  Perhaps fileManager?  I'd have to look at the larger context to see what the memory ownership is like here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list