[Webkit-unassigned] [Bug 44767] [EFL] WebCore depends on symbols from WebKit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44767


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #65737|review?                     |review-
               Flag|                            |




--- Comment #5 from Adam Barth <abarth at webkit.org>  2010-08-31 19:36:44 PST ---
(From update of attachment 65737)
View in context: https://bugs.webkit.org/attachment.cgi?id=65737&action=prettypatch

> WebCore/page/ContextMenuClient.h:60
> +#elif PLATFORM(EFL)
> +        virtual PlatformMenuDescription createPlatformDescription(ContextMenu*) = 0;
> +        virtual void freePlatformDescription(PlatformMenuDescription) = 0;
> +        virtual void appendItem(PlatformMenuDescription, ContextMenuItem&) = 0;
> +        virtual void show(PlatformMenuDescription menu) = 0;
I'm not sure we should have platform specific methods here.  I see that Mac does it, but that doesn't mean it's a good pattern.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.