[Webkit-unassigned] [Bug 44734] Add LocalFileSystem.requestFileSystem interface to DOMWindow

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44734


Jian Li <jianli at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #66121|review?                     |review-
               Flag|                            |




--- Comment #10 from Jian Li <jianli at chromium.org>  2010-08-31 16:22:21 PST ---
(From update of attachment 66121)
> WebCore/bindings/generic/RuntimeEnabledFeatures.h:141
> +    static bool requestFileSystemEnabled() { return isFileSystemEnabled; }
I still don't understand your comment. requestFileSystemEnabled() seems to be identical to fileSystemEnabled(). By looking into the name, I do not know what requestFileSystemEnabled is used for.

> WebCore/page/DOMWindow.cpp:742
> +    if (!document) {
Can this check be moved to the beginning of this method? That is, can we still call m_localFileSystem->requestFileSystem if document is gone?

> WebCore/page/DOMWindow.cpp:759
> +    m_localFileSystem->requestFileSystem(document, static_cast<AsyncFileSystem::Type>(type), size, successCallback, errorCallback);
This could be merged with the first call of "m_localFileSystem->requestFileSystem", like:
    if (!m_localFileSystem) {
       // Create m_localFileSystem
       ...
    }
    m_localFileSystem->requestFileSystem(document, static_cast<AsyncFileSystem::Type>(type), size, successCallback, errorCallback);

> WebCore/page/DOMWindow.h:86
> +    class LocalFileSystem;
Please move all these forward declarations to the right place.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.