[Webkit-unassigned] [Bug 39582] [Cairo] Enhance the performance of shadowed elements by tiling the shadow area

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39582


Dirk Schulze <krit at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #66129|review?                     |review-
               Flag|                            |




--- Comment #39 from Dirk Schulze <krit at webkit.org>  2010-08-31 16:18:49 PST ---
(From update of attachment 66129)
> WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:630
> +    if ((transform.isIdentityOrTranslationOrFlipped())) {
> +        cairo_t* cr = context->platformContext();;
Avoid multiple braces and muliple semicolons.

> WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:633
> +        FloatSize corner(0, 0);
No need for (0, 0), just use FloatSize corner;

> WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:1330
> +    OwnPtr<ImageBuffer> smallBuffer = ImageBuffer::create(smallBufferSize);
You should check if we realy got an imagebuffer.

> WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:1340
> +    OwnPtr<ImageBuffer> shadowBuffer = ImageBuffer::create(smallBufferSize);
dito

> WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:1378
> +    shadowBuffer->drawPattern(this, tileRect, patternTransform,
can be in one line

> WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:1388
> +    shadowBuffer->drawPattern(this, tileRect, patternTransform,
> +                              phase, colorSpace, CompositeSourceOver, destRect);
dito

> WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:1397
> +    shadowBuffer->drawPattern(this, tileRect, patternTransform,
> +                              phase, colorSpace, CompositeSourceOver, destRect);
dito

> WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:1405
> +    shadowBuffer->drawPattern(this, tileRect, patternTransform,
> +                              phase, colorSpace, CompositeSourceOver, destRect);
dito

> WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:1413
> +    shadowBuffer->drawPattern(this, tileRect, patternTransform,
> +                              phase, colorSpace, CompositeSourceOver, destRect);
dito

> WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:1421
> +    shadowBuffer->drawPattern(this, tileRect, patternTransform,
> +                              phase, colorSpace, CompositeSourceOver, destRect);
dito

> WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:1429
> +    shadowBuffer->drawPattern(this, tileRect, patternTransform,
> +                              phase, colorSpace, CompositeSourceOver, destRect);
dito

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.