[Webkit-unassigned] [Bug 44917] [chromium] Implement Readable/Writable versions of ChromiumDataObjectNew

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44917


Tony Chang <tony at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #66104|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #11 from Tony Chang <tony at chromium.org>  2010-08-31 15:56:23 PST ---
(From update of attachment 66104)
> +++ b/WebCore/platform/chromium/ClipboardMimeTypes.h
> +const char* const textPlainType = "text/plain";
> +const char* const textHtmlType = "text/html";
> +const char* const textUriListType = "text/uri-list";

This is the wrong way to make shared strings.  By putting the data in the header, the value will be copied into each .cpp file that includes this file.  An example of chromium code that does this is in base/base_switches.*.  Alternately, I would stick these values as static variables off an existing class.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.