[Webkit-unassigned] [Bug 44734] Add LocalFileSystem.requestFileSystem interface to DOMWindow

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44734





--- Comment #8 from Kinuko Yasuda <kinuko at chromium.org>  2010-08-31 15:02:11 PST ---
Thanks!

(In reply to comment #6)
> (From update of attachment 65846 [details])
> > WebCore/bindings/generic/RuntimeEnabledFeatures.h:141
> > +    static bool requestFileSystemEnabled() { return isFileSystemEnabled; }
> Why do we need requestFileSystemEnabled? What's the difference between fileSystemEnabled and requestFileSystemEnabled?

We need someIdlNameEnabled() method to dynamically enable someIdlName at the binding time.  I basically followed what the other code does here (have one boolean flag for the feature and associate the flag with multiple methods - though for now we have only one method associated with the flag).

> > WebCore/page/DOMWindow.h:83
> > +#if ENABLE(FILE_SYSTEM)
> Normally we do not need to guard this.

Removed.

> > WebCore/page/DOMWindow.h:86
> > +    class ErrorCallback;
> Please sort these.

Fixed.

> > WebCore/page/Settings.h:244
> > +        const String& fileSystemRootPath() const { return m_fileSystemRootPath; }
> Do you need to guard these?

Darin suggested that we may not need the ifdefs here.

> > WebKit/chromium/ChangeLog:15
> > +2010-08-27  Kinuko Yasuda  <kinuko at chromium.org>
> Why do you produce 2 ChangeLog entries?

Mistake... fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.