[Webkit-unassigned] [Bug 44734] Add LocalFileSystem.requestFileSystem interface to DOMWindow

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44734


Jian Li <jianli at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #65846|review?                     |review-
               Flag|                            |




--- Comment #6 from Jian Li <jianli at chromium.org>  2010-08-31 13:53:50 PST ---
(From update of attachment 65846)
> WebCore/bindings/generic/RuntimeEnabledFeatures.h:141
> +    static bool requestFileSystemEnabled() { return isFileSystemEnabled; }
Why do we need requestFileSystemEnabled? What's the difference between fileSystemEnabled and requestFileSystemEnabled?

> WebCore/page/DOMWindow.h:83
> +#if ENABLE(FILE_SYSTEM)
Normally we do not need to guard this.

> WebCore/page/DOMWindow.h:86
> +    class ErrorCallback;
Please sort these.

> WebCore/page/Settings.h:244
> +        const String& fileSystemRootPath() const { return m_fileSystemRootPath; }
Do you need to guard these?

> WebKit/chromium/ChangeLog:15
> +2010-08-27  Kinuko Yasuda  <kinuko at chromium.org>
Why do you produce 2 ChangeLog entries?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.