[Webkit-unassigned] [Bug 44127] [chromium] Thumbnails not generated for GPU Rendered Pages

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44127





--- Comment #34 from W. James MacLean <wjmaclean at chromium.org>  2010-08-31 13:31:13 PST ---
(In reply to comment #33)

I'll 

> have you considered replacing all of this code with some code that
> uses GraphicsContext and BitmapImage?  save for the GraphicsContext
> construction, i bet you could write some portable code for this if
> you used those classes.  WebFrameImpl::paint shows how to setup the
> GraphicsContext.

I can look into this, assuming the we agree the answer to the next question is 'yes'.

> One more comment:  is it really best to implement this using HW readback
> instead of just engaging the software painting path?

I would assume that using both the software and hardware paths is more resource intensive than using a single path, which in this case is (by definition) hardware. Secondly, presumably since we are using HW to speed things up, then this would also be desirable for thumbnail generation to also be accelerated (especially if the page is dynamic, and may need to be rendered repeatedly, meaning thumbnail generation could slow down subsequent page renders).

Finally, I don't know if it makes the controlling logic more complicated to have two different paths for rendering the same page, but I suspect it does.

Vangelis may have some additional thoughts here.

If you agree that HW readback is worthwhile for thumbnail generation, then I can proceed to look into the remaining issues.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.