[Webkit-unassigned] [Bug 44782] [GTK] ScrollbarThemeGtk should respond to theme changes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44782


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #65746|review?                     |review+
               Flag|                            |




--- Comment #2 from Gustavo Noronha (kov) <gns at gnome.org>  2010-08-31 11:42:20 PST ---
(From update of attachment 65746)
 89     // If the theme changed, update the thickness of every scrollbar widget.
 90     // The platform-independent scrollbar code isn't yet smart enough to
 91     // get this information when it paints.
 92     HashSet<Scrollbar*>::iterator end = gScrollbars->end();
 93     for (HashSet<Scrollbar*>::iterator it = gScrollbars->begin(); it != end; ++it) {
 94         Scrollbar* scrollbar = (*it);

Saying 'If the theme changed' seems to imply that we're depending on a conditional, but if we're in this function it's because the theme has changed, so I'd suggest only stating what is being done. Looks good otherwise!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.