[Webkit-unassigned] [Bug 43996] Add ability to count text matches without marking

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43996


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #66072|review?                     |review+
               Flag|                            |




--- Comment #5 from Darin Adler <darin at apple.com>  2010-08-31 10:47:29 PST ---
(From update of attachment 66072)
> +        // Do a "fake" paint in order to execute the code that computes the rendered rect for
> +        // each text match.

Merge comment into one line?

> +        Document* doc = document();
> +        if (m_view && contentRenderer()) {
> +            doc->updateLayout(); // Ensure layout is up to date.

Get rid of pointless local variable "doc"?

> -        unsigned markAllMatchesForText(const String&, bool caseFlag, unsigned limit);
> +        unsigned countMatchesForText(const String&, bool caseFlag, unsigned limit, bool markMatches);

A boolean for this is not great, since we’re often passing a constant. I suppose we can live with this, but it’s ugly.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.