[Webkit-unassigned] [Bug 39582] [Cairo] Enhance the performance of shadowed elements by tiling the shadow area

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39582





--- Comment #36 from Martin Robinson <mrobinson at webkit.org>  2010-08-31 09:25:43 PST ---
(From update of attachment 66061)
> WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:1285
> +
I think I prefer to switch this calculation around a bit to make it clearer. Consider:

// Find the extra space needed from the curve of the corners.
int extraWidthFromCornerRadii = max(topLeftRadius.width(), bottomLeftRadius.width()) + tileWidth + radiusTwice + max(topRightRadius.width(), bottomRightRadius.width();
int extraHeightFromCornerRadii = max(topLeftRadius.height(), topRightRadius.height()) + tileWidth + radiusTwice + max(bottomLeftRadius.height(), bottomRightRadius.height();

// The length of a side of the buffer is the enough space for two blur radii,
// the radii of the corners, and then 1 pixel to draw the side tiles.
IntSize smallBufferSize = IntSize((blurRadius * 2) + 1 + extraWidthFromCornerRadii,
                                  (blurRadius * 2) + 1 + extraHeightFromCornerRadii));

Notice that I renamed radius to blurRadius.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.