[Webkit-unassigned] [Bug 44863] Renderer ASSERT failure in Chrome when using click-to-play

Tue Aug 31 06:34:13 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=44863

Bernhard Bauer <bauerb at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #66043|                            |review?, commit-queue?
               Flag|                            |

--- Comment #3 from Bernhard Bauer <bauerb at chromium.org>  2010-08-31 06:34:12 PST ---
Created an attachment (id=66043)
 --> (https://bugs.webkit.org/attachment.cgi?id=66043)
Always run pending style recalcs when layouting.

It seems this is caused by a pending style recalculation when FrameView::layout is called. 

If a style recalc is pending, Document::updateStyleIfNeeded is called from m_frame->selection()->updateAppearance() in FrameView.cpp:784, which is after the layout has happened, so it sets the layout flag again.

My solution is to call updateStyleIfNeeded before layouting, which can conveniently done by moving it out of the else clause around FrameView.cpp:657.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.