[Webkit-unassigned] [Bug 44935] [Qt] Web process crash when pressing modifiers in input field

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44935





--- Comment #3 from Kimmo Kinnunen <kimmo.t.kinnunen at nokia.com>  2010-08-31 06:17:41 PST ---
(In reply to comment #2)
> (From update of attachment 66029 [details])
> > +#if defined(XP_UNIX)
> > +uint32_t PlatformKeyboardEvent::x11NativeModifiers() const
> > +{
> > +    ASSERT(m_qtEvent);
> > +    return m_qtEvent->nativeModifiers();
> > +}
> > +
> > +uint32_t PlatformKeyboardEvent::x11NativeScanCode() const
> > +{
> > +    ASSERT(m_qtEvent);
> > +    return m_qtEvent->nativeScanCode();
> > +}
> > +#endif
> 
> This is confusing. Can you explain what is the reason behind introducing these two Unix-only functions?

The idea is that X11 plugins can be supported even though PlatformKeyboardEvent may not be instantiated from QKeyEvent

In other words: the implementation tries to remove the notion that PlatformKeyboardEvent is QKeyEvent.

Otherwise we must synthetize QKeyEvent from WebKeyboardEvent. This is a bit redundant. On top of redundancy, this is not even possible, because there's no such a constructor for QKeyEvent (X11 Qt uses QKeyEventEx internally)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.