[Webkit-unassigned] [Bug 44931] [EFL] Add setting API for enabling page cache.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44931





--- Comment #3 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2010-08-31 03:29:12 PST ---
(In reply to comment #2)
> (From update of attachment 66017 [details])
> 
> > +Eina_Bool ewk_view_setting_page_cache_get(Evas_Object* o)
> 
> why not page_cache_enabled? it returns a bool not a page cache!

The ewk_view_setting_page_cache_get() just returns if page cache feature is enabled or not. This method doesn't return page cache.

In ewk_view.cpp, settings features like local_storage also have similar method.

Eina_Bool ewk_view_setting_spatial_navigation_get(Evas_Object* o)
{
     EWK_VIEW_SD_GET_OR_RETURN(o, sd, EINA_FALSE);
     EWK_VIEW_PRIV_GET_OR_RETURN(sd, priv, EINA_FALSE);
     return priv->settings.spatial_navigation;
}

Eina_Bool ewk_view_setting_local_storage_get(Evas_Object* o)
{
     EWK_VIEW_SD_GET_OR_RETURN(o, sd, EINA_FALSE);
     EWK_VIEW_PRIV_GET_OR_RETURN(sd, priv, EINA_FALSE);
     return priv->settings.local_storage;
}
...

I add a doxyzen for the method. However, if the naming can make confusion, I change the name.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.