[Webkit-unassigned] [Bug 43919] [GTK] Provide unit tests for AtkText's text selection functions

Tue Aug 31 03:18:40 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=43919

--- Comment #4 from Mario Sanchez Prada <msanchez at igalia.com>  2010-08-31 03:18:40 PST ---
(In reply to comment #3)
> (From update of attachment 64236 [details])
> I think I'd rather see these tests attached to the second patch. I'm 
> uncomfortable checking in code and tests separately. 

Not sure I follow you, but if I did it that way you'd still face the same problem when checking in the patch for bug 26991, as tests for it could be introduced until patch for bug 25673 was checked in as well.

Ok, you'd improve the situation in the way you'd be having the problem with just one bug instead of two, but I still think that's not a good enough reason to mess things up, IMHO.

Perhaps, after all, best thing here would be to merge all these three bugs into one new bug (+wontfixing the former ones, or something like that) and then provide one single patch with both implementations for get/set methods + the unit tests. You know... "One Patch to rule them all, One Patch to bring them all and in the darkness bind them" :-)

What do you think?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.