[Webkit-unassigned] [Bug 44928] New: commit-queue gets stuck if rollout fails and tree is red

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44928

           Summary: commit-queue gets stuck if rollout fails and tree is
                    red
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: eric at webkit.org
            Blocks: 44924


commit-queue gets stuck if rollout fails and tree is red

Recent Status

Patch 64903 from bug 44196: Landing patch 5 minutes ago
Unable to successfully build and test [results] 5 minutes ago
Patch 66003 from bug 44924: Landing rollout patch 17 minutes ago
Unable to successfully build and test [results] 17 minutes ago
Patch 66003 from bug 44924: Landing rollout patch 26 minutes ago
Unable to successfully build and test [results]

failure message:
http://webkit-commit-queue.appspot.com/results/3826166

I believe this is what's happening:

Normally the cq tries 3 times when landing a patch:

1.  applies patch, tries to build, run tests, if successful lands, stops processing.
2.  builds and tests w/o patch applied.  if fails, assumes tree is busted, stops processing, sleeps 2 minutes.
3.  applies patch, tries to build, run tests, if succeeds, lands.  if fails, rejects patch.

this allows us to deal with flaky tests better.


I believe we already have a bug about svn-apply failures going through these steps when instad they should fail out early.  Build errors should also fail early since they're never flaky.  That would solve the case seen today where the apply failed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.