[Webkit-unassigned] [Bug 44911] New: check-webkit-style should understand WTF #include guards
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Aug 30 17:21:14 PDT 2010
https://bugs.webkit.org/show_bug.cgi?id=44911
Summary: check-webkit-style should understand WTF #include
guards
Product: WebKit
Version: 528+ (Nightly build)
Platform: All
OS/Version: All
Status: NEW
Severity: Normal
Priority: P3
Component: Tools / Tests
AssignedTo: webkit-unassigned at lists.webkit.org
ReportedBy: kbr at google.com
CC: eric at webkit.org, abarth at webkit.org, crogers at google.com
Depends on: 44892
Many of the files in JavaScriptCore/wtf use a different #include guard than those used in WebCore; e.g., "#ifndef WTF_Vector_h" rather than "#ifndef Vector_h". This does seem to be a good idea to avoid clashes between potentially similarly-named headers in WTF and WebCore, since the #include style is different ('#include <wtf/Vector.h>' rather than '#include "Vector.h"'). check-webkit-style complains about the addition of new WTF_ prefixed #include guards; I think it should be taught about them. See https://bugs.webkit.org/show_bug.cgi?id=44892 for one instance where it complained.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list