[Webkit-unassigned] [Bug 38701] [chromium] don't call fontconfig twice in complex text path

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38701





--- Comment #35 from Adam Barth <abarth at webkit.org>  2010-08-30 16:26:25 PST ---
(From update of attachment 64925)
> WebCore/ChangeLog:11
> +        [chromium] don't call fontconfig twice in complex text path
> +        https://bugs.webkit.org/show_bug.cgi?id=38701
We usually put this information just under the "Reviewed by" line.

> WebCore/platform/graphics/chromium/FontCacheLinux.cpp:61
>  const SimpleFontData* FontCache::getFontDataForCharacters(const Font& font,
>                                                            const UChar* characters,
>                                                            int length)
These should be one line.

> WebCore/platform/graphics/chromium/FontCacheLinux.cpp:69
> +    // This cache is just leaked on shutdown.
That's true for mosts of our caches like this.  We don't need a comment explaining that.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.