[Webkit-unassigned] [Bug 44127] [chromium] Thumbnails not generated for GPU Rendered Pages

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44127





--- Comment #23 from Vangelis Kokkevis <vangelis at chromium.org>  2010-08-30 11:36:15 PST ---
(In reply to comment #21)
> (In reply to comment #20)
> > Looks good! Just one small comment on the bitmap format test and otherwise should be ready to go.
> > 
> > Hmm, is this still an issue? I see that in your patch you're using the PLATFORM() test. As far as I can tell, PLATFORM(SKIA/CG) expands out to WTF_PLATFORM_SKIA/CG . These two are defined in Platform.h, with WTF_PLATFORM_SKIA only defined if OS(DARWIN). 
> >
> 
> No, it seems fine. I'm not sure why I was having difficulty with it before, but it seems to be OK now.
> 
> > We probably need to be a bit more defensive here and bail out if the config is not what we expect, otherwise we'll end up with memory corruption. What about:
> > 
> > if (bitmap.config() == SkBitmap::kARGB_8888_Config) {
> > 
> > // do the stuff
> >  pixels = blah;
> > 
> > } else {
> >  ASSERT_NOT_REACHED();
> > }
> > 
> > And similarly for the mac code.
> 
> Done.

Sorry, one last thing that just occurred to me: alongside with the ASSERT_NOT_REACHED() we should also clear out the canvas we get passed in so that we don't end up displaying garbage. Painting it white should be sufficient.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.