[Webkit-unassigned] [Bug 44842] [CMake] Unify GENERATE_DOM_NAMES code

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 30 11:09:59 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=44842





--- Comment #2 from Leandro Pereira <leandro at profusion.mobi>  2010-08-30 11:09:59 PST ---
My only concern is linking to files related to disabled features. I know most files have preprocessor guards, but they'll be compiled and linked anyway. Since there are already tests for these features, I think it would be a good idea to enclose the GENERATE/append to sources list stuff inside these tests.

Besides that, the patch looks fine to me.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list