[Webkit-unassigned] [Bug 44261] [GTK] Add HTTP caching support

Mon Aug 30 07:35:03 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=44261

Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #65900|review?                     |review-
               Flag|                            |

--- Comment #37 from Gustavo Noronha (kov) <gns at gnome.org>  2010-08-30 07:35:03 PST ---
(From update of attachment 65900)
This will still need a changelog entry, and the build breakage implies we need to either depend on a newer glib or factor this code out if building with an oldish glib. There's a check in place to decide whether to use GSettings. I'd recommend adding a check specifically for GVariant, to decide whether to build this new code or not. I won't bother reviewing the actual code, except for the public APIs. The identation in soup-cache.c is completely broken (no spaces at all in various places, 4-space indentation in others), I think you may want to run indent in all soup cache files to have them match the libsoup style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.