[Webkit-unassigned] [Bug 38424] add support for text/html-sandboxed on sandboxed iframes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Aug 29 13:35:18 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=38424





--- Comment #23 from Darin Adler <darin at apple.com>  2010-08-29 13:35:18 PST ---
(From update of attachment 65708)
Looks good.

Why are some of the special cases for text/html-sandboxed inside #if but others not?

> @@ -2700,6 +2700,8 @@ void FrameLoader::committedLoad(Document
>  {
>      if (ArchiveFactory::isArchiveMimeType(loader->response().mimeType()))
>          return;
> +    if (equalIgnoringCase(loader->response().mimeType(), "text/html-sandboxed") && !isSandboxed(SandboxOrigin))
> +        return;
>      m_client->committedLoad(loader, data, length);
>  }

Can this possibly be right? It seems we treat this as an eternally uncommitted load rather than a failure. I don't think that's what we want. Is this really the right bottleneck?

I can’t say review+ because I don’t think the ifdefs are correct. But I don’t see anything I’m sure is wrong, so I’m not doing review- yet.

It seems quite error prone that in all these places we have separate text/html-sandboxed strings, and any could have a typo. Do we have sufficient test coverage so we'd get a failure if any one of these strings was wrong?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list