[Webkit-unassigned] [Bug 38354] Support for Percentage Values in border-radius

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38354


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #65066|review?                     |review+
               Flag|                            |




--- Comment #8 from Darin Adler <darin at apple.com>  2010-08-29 13:10:45 PST ---
(From update of attachment 65066)
> +        const int intMaxForLength = 0x7ffffff; // max value for a 28-bit int
> +        const int intMinForLength = (-0x7ffffff - 1); // min value for a 28-bit int

OK, but where does "28-bit" come from? I presume from Length. These constants should be in Length.h, not here inline in the code.

> +    BorderData() : m_topLeft(Length(0, Fixed), Length(0, Fixed)), m_topRight(Length(0, Fixed), Length(0, Fixed))
> +                 , m_bottomLeft(Length(0, Fixed), Length(0, Fixed)), m_bottomRight(Length(0, Fixed), Length(0, Fixed)) {}

This is not the correct formatting. Our style guide has a specific format for this:

    BorderData()
        : m_topLeft(Length(0, Fixed), Length(0, Fixed))
        , m_topRight(Length(0, Fixed), Length(0, Fixed))
        , m_bottomLeft(Length(0, Fixed), Length(0, Fixed))
        , m_bottomRight(Length(0, Fixed), Length(0, Fixed))
    {
    }

r=me, but please consider fixing the two issues above

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.