[Webkit-unassigned] [Bug 44595] DOM Selection: collapse() and selectAllChildren() should throw WRONG_DOCUMENT_ERR if node belongs to other document

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44595


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #65387|review?                     |review+
               Flag|                            |




--- Comment #5 from Darin Adler <darin at apple.com>  2010-08-29 11:44:24 PST ---
(From update of attachment 65387)
> +    const Document* selectionDocument = m_frame ? m_frame->document() : 0;
> +    const Document* nodeDocument = node ? node->document() : 0;

The const here does no good.

> +    const Document* selectionDocument = m_frame ? m_frame->document() : 0;

Same here.

I’d like this even better if the regression test covered the null frame and null node cases. I can't tell if it does.

r=me

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.