[Webkit-unassigned] [Bug 42390] Multi-layer backgrounds repaint (in low quality) every 0.5 seconds

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42390


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #61696|review?                     |review-
               Flag|                            |




--- Comment #10 from Darin Adler <darin at apple.com>  2010-08-29 11:42:03 PST ---
(From update of attachment 61696)
This seems more like a workaround than a fix. Just turns off the logic for layers that have a next pointer, with no comment or indication in the code why, and no regression test. We can do better.

> -            bool useLowQualityScaling = shouldPaintAtLowQuality(context, image, tileSize);
> +            bool useLowQualityScaling;
> +            if (bgLayer->next())
> +                useLowQualityScaling = false;
> +            else
> +                useLowQualityScaling = shouldPaintAtLowQuality(context, image, tileSize);

I think the logic would be easier to read like this:

    bool useLowQualityScaling = !bgLayer->next() && shouldPaintAtLowQuality(context, image, tileSize);

But still, we need an explanation for why we should paint multiple layer backgrounds always in high quality.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.