[Webkit-unassigned] [Bug 29000] Implement HTML5's fakepath

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Aug 29 11:39:06 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=29000


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39130|review?                     |review+
               Flag|                            |




--- Comment #16 from Darin Adler <darin at apple.com>  2010-08-29 11:39:05 PST ---
(From update of attachment 39130)
> +        if (!m_fileList->isEmpty()) {
> +            String value = "C:\\fakepath\\";
> +            value.append(m_fileList->item(0)->fileName());
> +            return value;
> +        }

This can be written just with the plus operator:

    if (!m_fileList->isEmpty())
        return C:\\fakepath\\" + m_fileList->item(0)->fileName();

I think that's more pleasant.

But also, I think that the fakepath will be mysterious without a comment.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list