[Webkit-unassigned] [Bug 44803] Decompose computing an element's computed language

Sat Aug 28 22:43:23 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=44803

Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ap at webkit.org

--- Comment #7 from Alexey Proskuryakov <ap at webkit.org>  2010-08-28 22:43:23 PST ---
> for the API at least, i recommend spelling out Language.

I think that it should be spelled out in internal function names, too.

But also, I don't think that "computedInheritedLanguage" is the right name - this function also takes node's own style into account.

+    // The language property is inherited, so we iterate over the parents to
+    // find the first language.

This is a very short comment, no need to split it into two lines.

I'm not sure how much benefit an API function provides over querying an element style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.