[Webkit-unassigned] [Bug 44734] Add LocalFileSystem.requestFileSystem interface to DOMWindow

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44734





--- Comment #2 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2010-08-27 23:26:24 PST ---
(From update of attachment 65794)
WebCore/page/DOMWindow.cpp:740
 +          errorCallback->handleEvent(FileError::create(INVALID_STATE_ERR).get());
i asked this question on the other code review, but shouldn't these dom events be
dispatched asynchronously?  otherwise, we end up nesting JS -> C++ -> JS calls,
which is never a great thing to do.  does the spec say anything about this?  it
seems like it would be nice to always dispatch callbacks asynchronously for
consistency.

WebCore/page/DOMWindow.cpp:759
 +  #define COMPILE_ASSERT_MATCHING_ENUM(domwindowname, asyncfsname) \
since there are only two enum values being compared here, it might not be worth defining the macro:

  COMPILE_ASSERT(int(DOMWindow::TEMPORARY) == int(AsyncFileSystem::Temporary), enum_mismatch);
  COMPILE_ASSERT(int(DOMWindow::PERSISTENT) == int(AsyncFileSystem::Persistent), enum_mismatch);

WebCore/page/Settings.h:243
 +  #if ENABLE(FILE_SYSTEM)
i don't know that this setting needs to be protected by the ifdef.
afterall, localStorageDatabasePath is not protected by ENABLE(DOM_STORAGE).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.