[Webkit-unassigned] [Bug 44732] Add DOMFileSystem implementation to support Entry manipulation operations

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44732





--- Comment #5 from Kinuko Yasuda <kinuko at chromium.org>  2010-08-27 17:55:31 PST ---
(In reply to comment #2)
> (From update of attachment 65653 [details])
> WebCore/storage/DOMFileSystem.cpp:102
>  +      if (newName.isEmpty() && DOMFilePath::getDirectory(src->fullPath()) == parent->fullPath())
> You also need to verify that newName is different than the existing name.

Fixed.

> WebCore/storage/DirectoryEntry.h:57
>  +      void getFile(const String& fullPath, PassRefPtr<Flags> options = 0, PassRefPtr<EntryCallback> successCallback = 0, PassRefPtr<ErrorCallback> errorCallback = 0);
> You've got fullPath here and path in some of the other files [e.g. DirectoryEntry.cpp].  If you want to emphasize that these are full paths, let's do it everywhere.

getFile and getDirectory can take either absolute path or relative path, so they must be |path|... fixed.
(In reply to comment #3)
> (From update of attachment 65653 [details])
> WebCore/storage/DOMFileSystem.cpp:157
>  +          errorCallback->handleEvent(FileError::create(INVALID_MODIFICATION_ERR).get());
> should this be dispatched asynchronously?  it seems like all events should be
> dispatched asynchronously for consistency.  plus nesting JS -> C++ -> JS can
> sometimes be problematic.

Changed to post a task that dispatches an error callback.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.