[Webkit-unassigned] [Bug 26276] Need a mechanism to determine stack extent

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26276





--- Comment #2 from Oliver Hunt <oliver at apple.com>  2010-08-27 11:30:36 PST ---
(In reply to comment #1)
> (In reply to comment #0)
> > There are many places where we have arbitrary (and conservative) recursion count based limits.  A better approach would be to have a guard based on the actual extent of the stack.
> 
> Would the limit based on the stack extent by also arbitrary, or is there a way to get reasonable values, say, per platform?

There doesn't seem to be any reliable way to get the thread stack size on *nix at least -- it's dependent on the attribute being set through pthreads, and i'm not sure if the attribute is required to correlate  to reality.

In the new parser I took a different approach and simply put a size limit by subtracting 512k (or something) from the first time we enter the parser on a given thread -- this assumes that the very first time we parse something we aren't already using too much stack space.  It also causes problems on platforms that have very low stack sizes :-/

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.