[Webkit-unassigned] [Bug 43988] Web Inspector: Remote Web Inspector support for QtWebKit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43988


Ariya Hidayat <ariya.hidayat at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #65715|review?                     |review-
               Flag|                            |




--- Comment #17 from Ariya Hidayat <ariya.hidayat at gmail.com>  2010-08-27 11:04:02 PST ---
(From update of attachment 65715)
First question: does everything still compile if we build without inspector support?

WebKit/qt/WebCoreSupport/InspectorServerQt.cpp:89
 +          sServer = new InspectorServerQt();
This is not deleted anywhere. To avoid intentional leak, make QCoreApplication::instance as the parent object so it gets deleted by the application on exit.

WebKit/qt/WebCoreSupport/InspectorServerQt.cpp:286
 +      m_tcpConnection = 0;
Any reason to only nullify this and not delete it? Although it will be deleted by the owning server socket, it will stay around in memory until the server socket dies.

WebKit/qt/WebCoreSupport/InspectorServerQt.cpp:151
 +      QTcpSocket* m_tcpConnection = m_tcpServer->nextPendingConnection();
This is a local variable, don't use m_ prefix (to avoid confusion with variables of the same name in another class).

WebKit/qt/WebCoreSupport/InspectorServerQt.cpp:324
 +          size_t length = pos - 1;
What happens if pos is 0 or 1?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.