[Webkit-unassigned] [Bug 44496] [EFL] Password manager for WebKit-Efl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44496





--- Comment #4 from Grzegorz <g.czajkowski at samsung.com>  2010-08-27 08:15:06 PST ---
Hi Rafael,

(In reply to comment #2)
> (In reply to comment #1)
> > Created an attachment (id=65229)
 --> (https://bugs.webkit.org/attachment.cgi?id=65229) [details] [details]
> > Password manager for WebKit-Efl
> Hi Grzegorz,
> Could you also update the comment section inside ewk_frame.h describing this new signal "submit,clicked"? It's in the beginning of that file, listing all available signals.

Good suggesetion. Added

> +void FrameLoaderClientEfl::submitClicked(const String &userName, const String &password, const KURL &url)
> +{
> +    ewk_frame_submit_clicked(m_frame, userName.latin1().data(), password.latin1().data(), url.string().latin1().data());
> +}
> Any reason for using latin1()? I see utf8() instead of that at least inside WebKit-EFL. Not sure which one would be correct, though.

You're right. Method latin1() has been changed to utf8()

> And are you aware that this code will only work if the password field is declared after the username field? Ok, I know that this probably covers 99% of the cases, just asking.

Yes. I am but as you noticed the scenario (username field and then password) covers the most cases. Frankly speaking I didn't see 

> Anyway, have you looked at th
e other ports implementation? I didn't find this, so couldn't compare.

I was looking at others ports implementation but I didn't find them. There isn't password manager for WebCore too. I will try to implement password manager for WebCore too.

> I would also put a better description on the ChangeLog. Maybe something like:
> "Added a signal "submit,clicked" when user clicks on a submit form.
> Also adding a function that fills username and password on the current view."

Changed

> And this patch also just works for the main_frame. What about pages with inner frames? Maybe this function should go to ewk_frame, and work on the called frame. What do you think about this?

That's a good idea.
I think it can resolve scenario when web page has more than one submit button. When user filled username and password to form and then he clicks submit button we will know from which frame it comes, right? 
Currently I marked this as FIXME 

Regards,
Grzegorz

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.