[Webkit-unassigned] [Bug 44679] Web Inspector: provide more information to front-end when breaking on DOM event

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44679


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #65707|review?                     |review-
               Flag|                            |




--- Comment #6 from Pavel Feldman <pfeldman at chromium.org>  2010-08-27 06:46:24 PST ---
(From update of attachment 65707)
WebCore/dom/ContainerNode.cpp:137
 +          InspectorController::willInsertDOMNode(this);
Passing child would look more consistent.

WebCore/inspector/InspectorController.h:387
 +      if (Page* page = node->document()->page()) {
Please replace nested ifs with guard expressions when nesting is that big.

WebCore/inspector/InspectorController.h:416
 +      if (Page* page = node->document()->page()) {
ditto

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.