[Webkit-unassigned] [Bug 43988] Web Inspector: Remote Web Inspector support for QtWebKit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43988





--- Comment #14 from Jamey Hicks <jamey.hicks at nokia.com>  2010-08-27 06:35:00 PST ---
(In reply to comment #13)
> (From update of attachment 65566 [details])
> 
> WebKit/qt/WebCoreSupport/InspectorServerQt.h:62
>  +      QMap<QWebPage*, InspectorClientQt*> m_inspectorClients;
> It is not clear for me why you use two maps. id to page and page to client.
> As I can see you can use simple map id to client.

Good point.

> WebKit/qt/WebCoreSupport/InspectorClientQt.cpp:266
>  +  void InspectorClientQt::dispatch(const String &message)
> Usually we are using InspectorClient only for sending messages to inspector.
> The dispatch implementation should be in InspectorFrontendClient.

I'll clean this up.

> 
> WebKit/qt/WebCoreSupport/InspectorClientQt.cpp:129

> 
> I think this portion of code can be simplified a bit.
> 1) m_remoteFrontend is unnecessary
> 2) m_inspectedWebPage is always not null
> In that case you can just check the RemoteFrontendChannel and if it is not established then try to use local inspector.

You are right. The code evolved over time and I did not notice that m_remoteInspector was no longer necessary.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.