[Webkit-unassigned] [Bug 44047] Stylesheets that use local references are treated as local to the SVG document

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44047





--- Comment #3 from Nikolas Zimmermann <zimmermann at kde.org>  2010-08-27 01:05:37 PST ---
(From update of attachment 65602)
WebCore/css/SVGCSSParser.cpp:97
 +              parsedValue = CSSPrimitiveValue::create(m_styleSheet->completeURL(value->string), CSSPrimitiveValue::CSS_URI);
I'm not sure about this approach, as CSSParser.cpp contains lots of

        // FIXME: The completeURL call should be done when using the CSSImageValue,
        // not when creating it.

for each instance of the code which uses m_styleSheet->completeURL(value->string)
That indicates it's not the right way to go for new code.

WebCore/css/SVGCSSStyleSelector.cpp:237
 +                     if (svgPaint->uri().startsWith("data:"))
I don't get that check? Where is that used? What implications does it have if you wouldn't handle it here?WebCore/css/SVGCSSStyleSelector.cpp:346
 +              if (s.startsWith("data:"))
Ditto.

WebCore/css/SVGCSSStyleSelector.cpp:365
 +              if (s.startsWith("data:"))
Ditto.

WebCore/css/SVGCSSStyleSelector.cpp:384
 +              if (s.startsWith("data:"))
Ditto.

WebCore/css/SVGCSSStyleSelector.cpp:426
 +              if (s.startsWith("data:"))
Ditto.

WebCore/css/SVGCSSStyleSelector.cpp:445
 +              if (s.startsWith("data:"))
Ditto.

WebCore/css/SVGCSSStyleSelector.cpp:464
 +              if (s.startsWith("data:"))
Ditto.

If it's somehow absolutely needed (can't tell w/o a test or ChangeLog), then you should at least refactor it into a shared function.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.