[Webkit-unassigned] [Bug 44508] [EFL] Add PlatformVideoWindowEfl.cpp for WebKit EFL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44508


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #65388|review?                     |review-
               Flag|                            |




--- Comment #25 from Martin Robinson <mrobinson at webkit.org>  2010-08-26 23:14:05 PST ---
(From update of attachment 65388)

> +#include "Widget.h"
> +
>  #include <wtf/PassRefPtr.h>

Please remove this extra line. There is no need to separate the include styles.

>  #if PLATFORM(GTK)
>  #include <gtk/gtk.h>
> -typedef GtkWidget PlatformWindowType;
> +#endif
> +
> +#if !PLATFORM(EFL) || ENABLE(GLIB_SUPPORT)
> +#include <glib.h>
>  #endif

Is the only reason for these #ifdefs and #includes gulong? Having
GLib and/or GTK+ includes in a header files can increase the compilation
time unecessarily. If possible, please just use unsigned long instead of
gulong and remove all the #ifdefs and #includes. Thanks!

> diff --git a/WebCore/platform/graphics/gstreamer/PlatformVideoWindowEfl.cpp b/WebCore/platform/graphics/gstreamer/PlatformVideoWindowEfl.cpp

Should this also be added to the CMake build scripts?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.