[Webkit-unassigned] [Bug 44667] check-webkit-style: test_expectation checker warns about new tests

Thu Aug 26 21:36:59 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=44667

Shinichiro Hamaji <hamaji at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |WORKSFORME

--- Comment #2 from Shinichiro Hamaji <hamaji at chromium.org>  2010-08-26 21:36:59 PST ---
Thanks for trying to fix this issue! However, as I wrote in Bug 41832, I think this is not a false-positive but a real warning. We might not need to "fix" this issue.

By the way, I've looked at your patch and had a thought. I think we should avoid **kwargs if possible. This feature is unsafe because it allows a typo. For example, it's difficult to find a bug in

checker.process_file("file/path", 42, added_file=["added/file"])

(added_file should be added_file*s*). I know **kwargs is useful for certain purpose, but in this case, I guess we don't need it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.