[Webkit-unassigned] [Bug 44732] Add DOMFileSystem implementation to support Entry manipulation operations

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44732





--- Comment #2 from Eric U. <ericu at chromium.org>  2010-08-26 18:19:33 PST ---
(From update of attachment 65653)
WebCore/storage/DOMFileSystem.cpp:102
 +      if (newName.isEmpty() && DOMFilePath::getDirectory(src->fullPath()) == parent->fullPath())
You also need to verify that newName is different than the existing name.

WebCore/storage/DirectoryEntry.h:57
 +      void getFile(const String& fullPath, PassRefPtr<Flags> options = 0, PassRefPtr<EntryCallback> successCallback = 0, PassRefPtr<ErrorCallback> errorCallback = 0);
You've got fullPath here and path in some of the other files [e.g. DirectoryEntry.cpp].  If you want to emphasize that these are full paths, let's do it everywhere.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.