[Webkit-unassigned] [Bug 44693] [WINCE] Port SoftLinking to WinCE

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44693


Adam Roben (aroben) <aroben at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #65614|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #3 from Adam Roben (aroben) <aroben at apple.com>  2010-08-26 14:24:20 PST ---
(From update of attachment 65614)
> +        Add a platformdependent macro for GetProcAddress.

Typo: platformdependent

> +#if OS(WINCE)
> +#define SOFT_LINK_GETPROCADDRESS(library, functionName) GetProcAddressW(library##Library(), L###functionName)
> +#else
> +#define SOFT_LINK_GETPROCADDRESS(library, functionName) GetProcAddress(library##Library(), #functionName)
> +#endif

Should we use GetProcAddressA on WinCE? GetProcAddress on NT is ANSI-only IIRC.

r+ since the code looks fine, but you should consider the above.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.