[Webkit-unassigned] [Bug 44642] js-test-post.js is not robust for asynchronous tests

Thu Aug 26 11:30:20 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=44642

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #65493|review?                     |review+
               Flag|                            |

--- Comment #2 from Darin Adler <darin at apple.com>  2010-08-26 11:30:20 PST ---
(From update of attachment 65493)
The change seems fine.

> +isAllScriptParsed = true;

I think that adding this new window property might affect tests that dump everything on the window object. Did you run all the scripts to test?

I would name this variable postTestScriptWasParsed or wasPostTestScriptParsed.

> +    if (window.isFinishJSTestCalled)

I would name this variable finishJSTestWasCalled or wasFinishJSTestCalled.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.