[Webkit-unassigned] [Bug 44518] Web Inspector: add audits support to extension API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44518


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #65557|                            |review+
               Flag|                            |




--- Comment #7 from Pavel Feldman <pfeldman at chromium.org>  2010-08-26 07:44:56 PST ---
(From update of attachment 65557)
LayoutTests/inspector/extensions-audits.html:15
 +          results.addResult("Passed rule", "this rule always passes ok", webInspector.audits.severity.info);
webInspector.audits.severity.info - too many letters! result.Severity.Info ?

WebCore/inspector/front-end/AuditsPanel.js:59
 +          this._launcherView.addCategory(this.categoriesById[id]);
indent.

WebCore/inspector/front-end/AuditsPanel.js:163
 +              category.run(resources, ruleResultReadyCallback.bind(null, result));
bind(null) looks strange.

LayoutTests/inspector/extensions-audits-expected.txt:13
 +  category.onAuditStarted fired, results dump follows:
It'd be great to dump APIs to a separate expectations file for better readability.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.