[Webkit-unassigned] [Bug 43779] RenderImage::imageChanged invalidates wrong area

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43779


Nikolas Zimmermann <zimmermann at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #65547|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #50 from Nikolas Zimmermann <zimmermann at kde.org>  2010-08-26 04:58:38 PST ---
(From update of attachment 65547)
WebCore/rendering/RenderImageResource.cpp:31
 +  #include "RenderImageResourceStyleImage.h"
This include is unncessary.

WebCore/rendering/RenderImageResource.cpp:44
 +      if (m_cachedImage)
You should also ASSERT(m_renderer) here.

WebCore/rendering/RenderImageResource.cpp:87
 +      if (!m_cachedImage)
And here (before the if).

WebCore/rendering/RenderImageResource.h:31
 +  #include "StyleImage.h"
Superfluous.

WebCore/rendering/RenderImageResource.h:37
 +  class StyleImage;
Superflous.


WebCore/rendering/RenderImageResource.h:69
 +      RenderObject* renderer() { return m_renderer; }
I'd remove these accesor, and rather make m_renderer protected.

WebCore/rendering/RenderImageResourceStyleImage.cpp:47
 +      m_styleImage->removeClient(renderer());
Just use m_renderer here, once it's protected.

WebCore/rendering/RenderImageResourceStyleImage.cpp:53
 +      m_styleImage->addClient(renderer());
Just use the passed newRenderer here.

It's a pity you can't land on your own yet, otherwhise I'd give r+.
Please fix and upload a new version again, that I can r+/cq+.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.